Fix *args/**kwargs return types. Add type hinting to py::make_tuple
#5881
+54
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Collaborator
|
@gentlegiantJGC Is there a chance that you could help formally reviewing (and approving) this PR? |
rwgk
approved these changes
Nov 14, 2025
Collaborator
rwgk
left a comment
rwgk
left a comment
There was a problem hiding this comment.
Thanks @gentlegiantJGC for the review!
Thanks @InvincibleRMC for jumping in to fix this!
Collaborator
|
Oh ... merge conflicts, @InvincibleRMC could you please resolve? |
Contributor
Author
should be good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on #5879. I noticed the return type of
py::args/py::kwargswas wrong.Update the return type of
py::args/py::kwargs. Also updatedmake_tupleto usetyping::Tuplesimilar to howmake_iteratorusestyping::Iterator.Suggested changelog entry: